Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan network interfaces once at startup #1704

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Scan network interfaces once at startup #1704

merged 3 commits into from
Jan 10, 2025

Conversation

OlivierHecart
Copy link
Contributor

Network interfaces scanning is a costly operation.
It was previously done at each link creation which leaded to significant CPU consumption at startup when lot of links were established.
Network interfaces scanning is now performed once at startup. The result of this initial scan is then used for the whole life of the process.

@OlivierHecart OlivierHecart requested a review from Mallets January 10, 2025 12:04
Copy link

PR missing one of the required labels: {'bug', 'new feature', 'breaking-change', 'documentation', 'dependencies', 'enhancement', 'internal'}

@OlivierHecart OlivierHecart added the enhancement Existing things could work better label Jan 10, 2025
@Mallets Mallets enabled auto-merge (squash) January 10, 2025 16:36
@sashacmc
Copy link
Member

sashacmc commented Jan 10, 2025

Shouldn't this be made configurable?
For example, in the case of VPN or something similar, interfaces can appear and disappear.
Some interfaces may not be there at the start, but will appear later, if the user wants to take this case into account, then such optimization can harm him.

@Mallets Mallets merged commit 573409f into main Jan 10, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing things could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants