Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: update static certificate with dynamic data #439

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

Faraz32123
Copy link

No description provided.

@Faraz32123 Faraz32123 self-assigned this Oct 27, 2023
@Faraz32123 Faraz32123 requested a review from ziafazal October 30, 2023 13:27
Copy link

@ziafazal ziafazal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Faraz32123 overall looks good. I think for datatime localization we should either rely on python or django instead of manually formatting date strings.

@Faraz32123 Faraz32123 force-pushed the enhancement/faraz-update_certificate branch from 9a6a695 to 6bdbb1a Compare October 30, 2023 13:35
@Faraz32123 Faraz32123 merged commit 9f99931 into sdaia-dev Oct 30, 2023
9 of 39 checks passed
@Faraz32123 Faraz32123 deleted the enhancement/faraz-update_certificate branch October 30, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants