Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Landscape mode Improvement #25

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

forgotvas
Copy link
Collaborator

Learn Page: Landscape mode Improvement openedx#475

All snapshots generated with dummy data:

1 2 3
Simulator Screenshot - iPhone 15 - 2024-07-10 at 00 03 54 Simulator Screenshot - iPhone 15 - 2024-07-10 at 00 04 22 Simulator Screenshot - iPhone 15 - 2024-07-10 at 00 04 41

@forgotvas forgotvas requested review from rnr and saeedbashir July 17, 2024 13:54
Copy link

@saeedbashir saeedbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Just confirming this special view is just for iPhone and not for iPad right?

@forgotvas
Copy link
Collaborator Author

Just confirming this special view is just for iPhone and not for iPad right?

Yes, it's based on isHorizontal environment:

var isHorizontal: Bool {
        if UIDevice.current.userInterfaceIdiom != .pad {
            if let windowScene = UIApplication.shared.connectedScenes.first as? UIWindowScene {
                return windowScene.windows.first?.windowScene?.interfaceOrientation.isLandscape ?? true
            }
        }
        return false
    }

@rnr rnr merged commit f114083 into 2U/develop Jul 17, 2024
3 checks passed
@rnr rnr deleted the 2U/feat/primary-horizontal branch July 17, 2024 20:27
rnr added a commit that referenced this pull request Oct 1, 2024
rnr added a commit that referenced this pull request Oct 8, 2024
* Merge pull request #23 from edx/small-fix-for-downloading-cancelling

fix: fixes for downloading

* chore: fix for Xcode 16 and after merge

* Merge pull request #24 from edx/2U/fix/download-states

fix: [iOS] On Course "Home" tab the row height

* fix: after merge, deleted IAP part

fix: [iOS] On Course "Home" tab the row height

* Merge pull request #25 from edx/2U/feat/primary-horizontal

feat: Landscape mode Improvement

* fix: removed IAP part

* chore: remove snack bar error for course dates info API on course home (#27)

* Merge pull request #28 from shafqat-muneer/Shafqat/LEARNER-10020-ErrorHandling

feat: Course Level Error Handling for Empty States

* chore: remove IAP part after merging

---------

Co-authored-by: Anton Yarmolenko <[email protected]>
Co-authored-by: Saeed Bashir <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants