Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade to Node 20, Removed Node 18 support #50

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

BilalQamar95
Copy link
Contributor

Description

  • Regenerated package-lock.json with node v20 and NPM 10.
  • Updated .nvmrc to v20
  • Updated the lockfile version check workflow

Second step in the Node 20 upgrade process, See the tracking issue for further information.

@BilalQamar95 BilalQamar95 self-assigned this Oct 22, 2024
@BilalQamar95 BilalQamar95 mentioned this pull request Oct 22, 2024
Copy link
Member

@varshamenon4 varshamenon4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@BilalQamar95
Copy link
Contributor Author

lgtm!

@varshamenon4 Can you please help merge this? It's blocked due to idled test Expected — Waiting for status to be reported and in order to merge this we need to temporarily remove the test check as a required status.

This issue is because the CI workflow was updated to include a test matrix for Node versions 18 and 20. Since the test job is marked as a required check, it expects a single status to be reported. With the matrix setup, tests are now running separately for both Node versions, causing the status check to get stuck on idle.

@BilalQamar95 BilalQamar95 changed the title build: Upgrade to Node 20 build: Upgrade to Node 20, Removed Node 18 support Nov 4, 2024
@BilalQamar95 BilalQamar95 merged commit b837a8b into main Nov 4, 2024
3 checks passed
@BilalQamar95 BilalQamar95 deleted the bilalqamar95/node20-upgrade-2 branch November 4, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants