modify MPGD BOT ACTS tolerance #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdconinc
approved these changes
Nov 7, 2024
|
@veprbl backport into 24.11 label added |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-actions bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
### Briefly, what does this PR introduce? Fixes the [issue #1659 in EICrecon](eic/EICrecon#1659) where the last tracker hit was not being used in CKF. [2024_11_06.pdf](https://github.com/user-attachments/files/17661610/2024_11_06.pdf) ### What kind of change does this PR introduce? - [ x] Bug fix: [EICrecon issue#1659](eic/EICrecon#1659) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [x ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No breaking changes. Analyzers will now see all outer barrel MPGD hits included in the CKF. ### Does this PR change default behavior? No (cherry picked from commit d491ba7)
|
Successfully created backport PR for |
veprbl
pushed a commit
that referenced
this pull request
Nov 11, 2024
# Description Backport of #800 to `24.11`. Co-authored-by: Matt Posik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Fixes the issue #1659 in EICrecon where the last tracker hit was not being used in CKF.
2024_11_06.pdf
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No breaking changes. Analyzers will now see all outer barrel MPGD hits included in the CKF.
Does this PR change default behavior?
No