Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for node greater than 16, upgrade Node to v20 #558

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

digitalsadhu
Copy link
Member

Started looking at converting the codebase to ESM and ran into this little hitch along the way.

@wkillerud
Copy link
Contributor

wkillerud commented Jul 29, 2024

Test failure on Windows here (and for other PRs) is (at least partly) because of eik-lib/common#303

@wkillerud wkillerud merged commit ee93a4b into main Jul 29, 2024
2 checks passed
@wkillerud wkillerud deleted the fix_tests_for_node_gt_16 branch July 29, 2024 07:15
Copy link

🎉 This PR is included in version 2.0.39 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests seem to fail on Node > 16 Outdated configurations for builds
2 participants