Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DataChannel support optional #163

Merged
merged 3 commits into from
Aug 29, 2024

Add the optional `ex_sctp` in the chat example

1940150
Select commit
Loading
Failed to load commit list.
Merged

Make DataChannel support optional #163

Add the optional `ex_sctp` in the chat example
1940150
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 29, 2024 in 0s

87.58% (-0.06%) compared to e79d429

View this Pull Request on Codecov

87.58% (-0.06%) compared to e79d429

Details

Codecov Report

Attention: Patch coverage is 82.55814% with 30 lines in your changes missing coverage. Please review.

Project coverage is 87.58%. Comparing base (e79d429) to head (1940150).

Files with missing lines Patch % Lines
lib/ex_webrtc/sctp_transport.ex 82.45% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
- Coverage   87.64%   87.58%   -0.06%     
==========================================
  Files          40       40              
  Lines        2225     2231       +6     
==========================================
+ Hits         1950     1954       +4     
- Misses        275      277       +2     
Files with missing lines Coverage Δ
lib/ex_webrtc/peer_connection.ex 85.90% <100.00%> (ø)
lib/ex_webrtc/sctp_transport.ex 82.08% <82.45%> (-0.56%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79d429...1940150. Read the comment docs.