Improve ProxyHeadersMiddleware #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Marcelo Trylesinski <[email protected]>
Co-authored-by: Marcelo Trylesinski <[email protected]>
raf-moreau
pushed a commit
to raf-moreau/uvicorn
that referenced
this pull request
Nov 5, 2024
* Allow ip ranges for FORWARDED_ALLOW_IPS * Fix host for empty x-forwarded-for header * Add multi-host ip-range testcase, run scripts/lint * Re-run black with line-length 88 * Wrap comments to fit in line-length * Another missed line-length violation * Fix __contains__ annotations * Add support for IPv6 * Fix linting * Fix test cases * Update docs, comments * Update index's usage * Fix more linting * Better unix socket support * Expand proxy documentation * More docs and code comments * Refactor common test cases, add cases for UDS * Update settings docs * Remove "better UDS handling" * Remove code leading to coverage failures * Apply suggestions from code review Co-authored-by: Marcelo Trylesinski <[email protected]> * Fixes, and more tests * Update uvicorn/config.py Co-authored-by: Marcelo Trylesinski <[email protected]> * Run ruff formatter * Replace cast with type: ignore * remove make_x_headers * nitpicks * remove unneeded return * fix docs --------- Co-authored-by: Patrick Düggelin <[email protected]> Co-authored-by: Nicholas Hairs <[email protected]> Co-authored-by: Nicholas Hairs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't push changes to that branch, so I open this branch.