Fixes some loose secrets handling #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes logging of base64 strings - Adds explicit GHA masking for the base64 strings - Consume the base64 strings via environment variables in GHA scripts, to avoid another logging disclosure scenario
Test Results1 tests 1 ✅ 0s ⏱️ Results for commit 83d91d5. ♻️ This comment has been updated with latest results. |
Code Coverage Summary Report - Linux (No TFM)Summary
CoverageTestLib - 100%
TestLib.Tests - 100%
|
Code Coverage Summary Report - Linux (net8.0)Summary
CoverageTestLib - 100%
TestLib.Tests - 100%
|
Code Coverage Summary Report - Windows (net8.0)Summary
CoverageTestLib - 100%
TestLib.Tests - 100%
|
mwadams
reviewed
Feb 12, 2025
idg10
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
So if I've understood correctly, there are three changes here:
- we no longer dump out the base64 with the secrets
- we no longer dump out the base64 with the non-secret environment variables
- we tell GitHub that if it ever sees the text of the base64 with the secrets in log output, it should mask it.
So 1 is the problem originally identified. 3 is an additional 'belt and braces' step to ensure that if anything else tries to do the same thing, it'll be blocked. And 2 doesn't seem directly concerned with secret handling, but I'm guessing that both of these Write-Host lines were diagnostic code that wasn't meant to be left in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the following composite actions:
prepare-env-vars-and-secretsset-env-vars-and-secretsSummary of changes: