Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some loose secrets handling #108

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Fixes some loose secrets handling #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions actions/prepare-env-vars-and-secrets/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ runs:
$yaml = ConvertFrom-Yaml $srcEnvVars | ConvertTo-Yaml
Write-Host "yaml: $yaml"
$yamlb64 = [Convert]::ToBase64String([System.Text.Encoding]::Unicode.GetBytes($yaml))
Write-Host "yamlb64: $yamlb64"
("RESOLVED_ENV_VARS={0}" -f $yamlb64) | Out-File -Append $env:GITHUB_OUTPUT
shell: pwsh

Expand All @@ -48,6 +47,6 @@ runs:
$yaml = ConvertFrom-Yaml $srcSecrets | ConvertTo-Yaml
Write-Host "yaml: $yaml"
$yamlb64 = [Convert]::ToBase64String([System.Text.Encoding]::Unicode.GetBytes($yaml))
Write-Host "yamlb64: $yamlb64"
Write-Host ("::add-mask::{0}" -f $yamlb64)
("RESOLVED_SECRETS={0}" -f $yamlb64) | Out-File -Append $env:GITHUB_OUTPUT
shell: pwsh
11 changes: 8 additions & 3 deletions actions/set-env-vars-and-secrets/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,25 @@ runs:
- id: setEnvironmentVariables
name: Set Environment Variables
run: |
$envVarsYaml = [System.Text.Encoding]::Unicode.GetString([Convert]::FromBase64String("${{ inputs.environmentVariablesYamlBase64 }}"))
$envVarsYaml = [System.Text.Encoding]::Unicode.GetString([Convert]::FromBase64String($env:INCOMING_ENV_VARS))
$envVars = ConvertFrom-Yaml $envVarsYaml
foreach ($envVarName in $envVars.Keys) {
('{0}={1}' -f $envVarName, $envVars[$envVarName]) | Out-File -Append -FilePath $env:GITHUB_ENV
}
shell: pwsh
env:
INCOMING_ENV_VARS: ${{ inputs.environmentVariablesYamlBase64 }}
- id: setSecrets
name: Set Secrets
run: |
Import-Module Powershell-yaml
$secretsYaml = [System.Text.Encoding]::Unicode.GetString([Convert]::FromBase64String("${{ inputs.secretsYamlBase64 }}"))
Write-Host ("::add-mask::{0}" -f $env:INCOMING_SECRETS)
$secretsYaml = [System.Text.Encoding]::Unicode.GetString([Convert]::FromBase64String($env:INCOMING_SECRETS))
$secrets = ConvertFrom-Yaml $secretsYaml
foreach ($secretName in $secrets.Keys) {
('{0}={1}' -f $secretName, $secrets[$secretName]) | Out-File -Append -FilePath $env:GITHUB_ENV
Write-Host ("::add-mask::{0}" -f $secrets[$secretName])
}
shell: pwsh
shell: pwsh
env:
INCOMING_SECRETS: ${{ inputs.secretsYamlBase64 }}
Loading