-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix updating conflicting project #11111
Conversation
f379aa9
to
2a61273
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR ✅
Tested on my Windows box - neither the Update or Rename buttons appear to work. |
@MrFlashAccount its another PR without any description nor issue. If the bug was reported with discord and there is no issue please create it yourself (its enough to copy paste from discord or insert screenshot and attach to the iteration) or ping me to provide it to you. |
cf197d5
to
eef911a
Compare
eef911a
to
56d1b00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't remove the functionality from local.
Lets work with @4e6 and @hubertp and get the behavior correct.
Cloud and Local should be the same.
- If no conflict imported named as in the enso-archive.
- If conflict, dialog should be shown.
- If update then replace existing.
- If rename then add (n) to make unique.
And this should be the case regardless of how the project was "imported" - button, drag drop, double click in OS.
@jdunkerley reverted the update functionality back, created an issue: #11166 |
af3db4e
to
af29937
Compare
Pull Request Description
This PR fixes a bug, when uploading a duplicate project to local backend threw a crash on windows.
https://github.com/user-attachments/assets/fe1bd7a7-d840-4bb1-b3f6-e0beec70fcd4
I found a bug when we upload a project to a remote backend, it throws a 500 error. Notified @PabloBuchu about that.
Also, @hubertp proved that the ProjectManager always duplicates a project no matter which option we choose(either "update" or "rename“). So I removed the "update" button if we upload a project locally
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.