Accessing and modifying description and labels of Enso Cloud assets

[radeusgd]

Pull Request Description

• Closes Access metadata of Enso Cloud assets programmatically #11227
• Additionally, it should fix Often random failures of Audit_Spec on the CI #11278 by ensuring that every scheduled message goes to the desired endpoint, by splitting each batch by endpoint.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• The documentation has been updated, if necessary.
• Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
• All code follows the
  Scala,
  Java,
  TypeScript,
  and
  Rust
  style guides. In case you are using a language not listed above, follow the Rust style guide.
• Unit tests have been written where possible.

[GregoryTravis]

It would be nice to have this as Vector.remove_element.

[radeusgd]

Indeed, but adding it I'd have to add unit tests for it and I don't want to postpone this PR.

Let's add it in a separate PR when we see it used more, or see a need for it for end-users.

[jdunkerley]

Generally looks good - a few suggestions.

[jdunkerley]

Suggested change

	Context.Output.if_enabled disabled_message="Cannot add a label when writing is disabled. Press the Write button ▶ to perform the operation." panic=False <|
	labels = self.labels
	if labels.contains label then self else
	ensure_tags_exist [label] . if_not_error <|
	new_labels = labels+[label]
	update_asset_labels self new_labels . if_not_error self
	labels = self.labels
	if labels.contains label then self else
	ensure_tags_exist [label] . if_not_error <|
	new_labels = labels+[label]
	Context.Output.if_enabled disabled_message="Cannot add a label when writing is disabled. Press the Write button ▶ to perform the operation." panic=False <|
	update_asset_labels self new_labels . if_not_error self

Could make it only check the context as last step then allow user to fix issue

[radeusgd]

No, we shouldn't change the order. Perhaps I should rename the ensure_tags_exist method to make it clearer.

This method creates tags if they don't exist. So it is a method with side-effects, that calls into the Cloud. Hence, it itself should be behind the Output context.

I will rename the method to create_tags_if_not_exist to make it clearer that this is more than a pre-check.

[radeusgd]

But I can indeed move the contains check before context check 👍

Sorry at first I did not notice this part

[jdunkerley]

worth routing this through set_labels?

[radeusgd]

I was thinking of it, but then the message if Context was disabled would be 'Cannot set labels...', but I wanted a more appropriate/precise 'Cannot add a label'.

[jdunkerley]

worth testing existance?

[radeusgd]

OK. Although ideally that should be checked on the cloud side and only a special error returned.

[jdunkerley]

Suggested change

	## PRIVATE
	new_with_metadata id:Text title:Text metadata:Asset_Metadata -> Existing_Enso_Asset =
	Existing_Enso_Asset.Value title id (asset_type_from_id id) metadata
	## PRIVATE
	new id:Text title:Text metadata:(Nothing|Asset_Metadata)=Nothing -> Existing_Enso_Asset =
	Existing_Enso_Asset.Value title id (asset_type_from_id id) metadata

Could we not have a single new here?

[radeusgd]

I wanted to make it very clear when the asset is constructed with or without metadata. IMO it is a bit clearer when this is verbose. But I can merge them - initially there were more differences in the logic, now indeed it's very similar