Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh the version of hessian2-code dependency #38005

Merged
merged 2 commits into from
Jan 14, 2025

Update release date for hessian2

d968ccd
Select commit
Loading
Failed to load commit list.
Merged

Refresh the version of hessian2-code dependency #38005

Update release date for hessian2
d968ccd
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Envoy/Publish and verify succeeded Jan 14, 2025 in 25m 6s

Envoy/Publish and verify (success)

Check has finished

Details

Check run finished (success ✔️)

The check run can be viewed here:

Envoy/Publish and verify (pr/38005/main@d968ccd)

Check started by

Request (pr/38005/main@d968ccd)

krinkinmu @krinkinmu d968ccd #38005 merge main@b0f43d6

Refresh the version of hessian2-code dependency

Commit Message:

The new version includes alibaba/hessian2-codec#37 that contains a fix for one of the issues listeed in #37911 (number 5 on the list).

TL;DR: the issue is that in hessian2-codec the same cc file is used as a source for two different libraries. The code that depends on both of those libraries at the same time might have an issue because of the same source used several times.

Additional Description: Related to #37911

Risk Level: Low

Testing:

Tested that Envoy builds with introduced changes, additionally run unit tests in //test/extensions/common/dubbo/... //test/extensions/filters/network/dubbo_proxy/... and //test/extensions/filters/network/generic_proxy/codecs/dubbo/....
dubbo is the extension that uses hessian2 codec (the full test suite will run as part of the PR checks as well).

Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Environment

Request variables

Key Value
ref a75e97d
sha d968ccd
pr 38005
base-sha b0f43d6
actor krinkinmu @krinkinmu
message Refresh the version of hessian2-code dependency...
started 1736888066.145965
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:d2be0c198feda0c607fa33209da01bf737ef373f
mobile envoyproxy/envoy-build-ubuntu:mobile-d2be0c198feda0c607fa33209da01bf737ef373f
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 33
patch 0
dev false