-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated interface for accumulation #851
Conversation
Table: Benchmarking results (mean time in seconds).
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 08814c4 is merged into main:
|
Thanks for the comments/suggestions - I've updated the argument names as suggested and did a pass through the docs in an attempt to make them clearer. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if fd020b6 is merged into main:
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 9a8ef8e is merged into main:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me and happy for it to be merged. I have a open comment with a last check about the interaction between accumulation and truncation (which I think I already raised and so is likely easy to dismiss)
CI failures are unrelated to this PR (trying and failing to download R) so I am happy to ignore them |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if abb8d1c is merged into main:
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if fc91c49 is merged into main:
|
Thanks all for the comments/reviews - merging now as failed checks are unrelated. |
Description
This PR closes #547 following the design agreed in #839.
Initial submission checklist
devtools::test()
anddevtools::check()
).devtools::document()
).lintr::lint_package()
).After the initial Pull Request