-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #485: Fix linting #509
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #509 +/- ##
========================================
Coverage 81.21% 81.21%
========================================
Files 20 20
Lines 1725 1725
========================================
Hits 1401 1401
Misses 324 324 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely looks better. I think shortening the name is fine. Still failing as its flagging all the lines that are new and don't have test coverage.
I think I addressed all your comments. Are you happy for me to merge? In particular, should we address tests in a different PR, or would you prefer doing this now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR closes #485
This PR fixes linting issues on the current development branch. It
Two single items stand out:
interval_coverage_deviation_quantile
is too longplot.scoringutils_available_forecasts
is too longWe could simply change
interval_coverage_deviation_quantile
tointerval_coverage_dev_quantile
(exactly 30 chars long). An alternative would be to simply exclude the line from linting.The second one is related to #403.
Update 1 I created a second PR for the name of
plot.scoringutils_available_forecasts()
, #511, which addresses #403Update 2 I renamed the function to
interval_coverage_dev_quantile
Checklist
I have added or updated unit tests where necessary.I have updated the documentation if required.lintr::lint_package()
to check for style issues introduced by my changes.I have added a news item linked to this PR.