-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export config from module #93
Conversation
Fixes #65 |
@displague bump on this PR; is there anything else you're looking for? |
@displague good call outs. I took care of them, except for the variable part of the kubeconfig export; path.root as a default isn't valid |
I ran into a provisioning problem, @keithmattix:
Perhaps this is a racing issue?
|
@displague I figured it out; there was a race between when Terraform marked the primary node as ready and when the setup script actually finished executing. I added a |
|
||
output "kubernetes_kubeconfig" { | ||
description = "Kubeconfig for the newly created cluster" | ||
value = module.controllers.kubeconfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value = module.controllers.kubeconfig | |
value = module.controllers.kubeconfig | |
sensitive = true |
|
||
output "kubeconfig" { | ||
description = "Kubeconfig for the newly created cluster" | ||
value = data.local_file.kubeconfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value = data.local_file.kubeconfig | |
value = abspath(data.local_file.kubeconfig) |
The current module outputs aren't great; this PR takes a stab at fixing that by exporting the kubeconfig from the controller module.