Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport logging of long forward model time steps. #9123

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented Nov 1, 2024

Issue
Resolves #my_issue

Approach
Squash three commits from main (two fixups)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland changed the base branch from main to version-11.0 November 1, 2024 08:24
@berland berland self-assigned this Nov 1, 2024
@berland berland added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Nov 1, 2024
There are more short forward model time steps than we want the logging
system to handle, thus steps taking less than 2 minutes are skipped.
@berland berland force-pushed the version-11.0-logfmstep branch from fa312b4 to 6ef39e4 Compare November 1, 2024 09:41
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.41%. Comparing base (5a220c7) to head (6ef39e4).

Files with missing lines Patch % Lines
src/ert/ensemble_evaluator/_ensemble.py 88.23% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           version-11.0    #9123      +/-   ##
================================================
- Coverage         91.42%   91.41%   -0.02%     
================================================
  Files               343      343              
  Lines             21335    21351      +16     
================================================
+ Hits              19506    19518      +12     
- Misses             1829     1833       +4     
Flag Coverage Δ
cli-tests 39.07% <88.23%> (+0.04%) ⬆️
gui-tests 72.39% <82.35%> (-0.03%) ⬇️
performance-tests 49.29% <76.47%> (+0.06%) ⬆️
unit-tests 79.99% <82.35%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sondreso sondreso merged commit dd35db4 into equinor:version-11.0 Nov 1, 2024
35 checks passed
@berland berland deleted the version-11.0-logfmstep branch December 27, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants