Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport logging of long forward model time steps. #9123

Merged
merged 1 commit into from
Nov 1, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 44 additions & 1 deletion src/ert/ensemble_evaluator/_ensemble.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,15 @@
Union,
)

from _ert.events import Event, Id, event_from_dict, event_to_json
from _ert.events import (
Event,
FMEvent,
ForwardModelStepFailure,
ForwardModelStepSuccess,
Id,
event_from_dict,
event_to_json,
)
from _ert.forward_model_runner.client import Client
from ert.config import ForwardModelStep, QueueConfig
from ert.run_arg import RunArg
Expand Down Expand Up @@ -142,9 +150,44 @@ def _create_snapshot(self) -> EnsembleSnapshot:
def get_successful_realizations(self) -> List[int]:
return self.snapshot.get_successful_realizations()

def _log_completed_fm_step(
self, event: FMEvent, step_snapshot: Optional[FMStepSnapshot]
) -> None:
if step_snapshot is None:
logger.warning(f"Should log {event}, but there was no step_snapshot")
return
step_name = step_snapshot.get("name", "")
start_time = step_snapshot.get("start_time")
cpu_seconds = step_snapshot.get("cpu_seconds")
current_memory_usage = step_snapshot.get("current_memory_usage")
if start_time is not None and event.time is not None:
walltime = (event.time - start_time).total_seconds()
else:
# We get here if the Running event is in the same event batch as
# the Success event. That means that runtime is close to zero.
walltime = 0

if walltime > 120:
logger.warning(
f"{event.event_type} {step_name} "
f"{walltime=} "
f"{cpu_seconds=} "
f"{current_memory_usage=} "
f"step_index={event.fm_step} "
f"real={event.real} "
f"ensemble={event.ensemble}"
)

def update_snapshot(self, events: Sequence[Event]) -> EnsembleSnapshot:
snapshot_mutate_event = EnsembleSnapshot()
for event in events:
if isinstance(event, (ForwardModelStepSuccess, ForwardModelStepFailure)):
step = (
self.snapshot.reals[event.real]
.get("fm_steps", {})
.get(event.fm_step)
)
self._log_completed_fm_step(event, step)
snapshot_mutate_event = snapshot_mutate_event.update_from_event(
event, source_snapshot=self.snapshot
)
Expand Down