Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename enabled to isarConnected #1489

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Rename enabled to isarConnected #1489

merged 2 commits into from
Mar 22, 2024

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Mar 22, 2024

No description provided.

@Eddasol Eddasol added backend Backend related functionality improvement Improvement to existing functionality frontend Frontend related functionality labels Mar 22, 2024
@Eddasol Eddasol self-assigned this Mar 22, 2024
@Eddasol Eddasol linked an issue Mar 22, 2024 that may be closed by this pull request
Copy link

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@@ -134,7 +134,7 @@ export class BackendAPICaller {
static async getEnabledRobots(): Promise<Robot[]> {
const path: string = 'robots'
const result = await BackendAPICaller.GET<Robot[]>(path).catch(BackendAPICaller.handleError('GET', path))
return result.content.filter((robot) => robot.enabled)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the name of this function (getEnabledRobots) hasn't been changed, as this function will be rewritten to sort on deprecated instead in separate PR

Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Mar 22, 2024
@Eddasol Eddasol force-pushed the set-offline branch 2 times, most recently from ef77ef6 to b916506 Compare March 22, 2024 11:56
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eddasol
Copy link
Contributor Author

Eddasol commented Mar 22, 2024

/UpdateDatabase

Copy link

👀 Running migration command... 👀

Copy link

✨ Successfully ran migration command! ✨

@Eddasol Eddasol merged commit 01f9215 into equinor:main Mar 22, 2024
12 checks passed
@Eddasol Eddasol deleted the set-offline branch March 22, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality database-change Will require migration frontend Frontend related functionality improvement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change name from "Enabled" to "isarConnected"
2 participants