Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mission starting stability #1889

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Improve mission starting stability #1889

merged 4 commits into from
Dec 17, 2024

Conversation

andchiind
Copy link
Contributor

@andchiind andchiind commented Dec 16, 2024 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@andchiind andchiind added bug Something isn't working backend Backend related functionality labels Dec 16, 2024
@andchiind andchiind self-assigned this Dec 16, 2024
@andchiind andchiind force-pushed the ignore-ongoing-mission branch from 6c663f4 to f2d9d45 Compare December 16, 2024 16:32
@andchiind andchiind linked an issue Dec 17, 2024 that may be closed by this pull request
Put missions on queue if ISAR already has a mission running #1879
Closed
oysand
oysand requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should still only pass the robot id. I suspect that the OnIsarRobotInfo might be the culprint that is setting the robot object to busy

oysand
oysand requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See remaining comments

@andchiind andchiind force-pushed the ignore-ongoing-mission branch 3 times, most recently from 62f2b8b to b4b83cc Compare December 17, 2024 11:13
@andchiind
Copy link
Contributor Author

Relevant new issue: #1891

@andchiind andchiind force-pushed the ignore-ongoing-mission branch from b4b83cc to 4cf6b35 Compare December 17, 2024 11:23
oysand
oysand approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oysand oysand merged commit 7996d46 into equinor:main Dec 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oysand oysand oysand approved these changes

Assignees

@andchiind andchiind

Labels
backend Backend related functionality bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Put missions on queue if ISAR already has a mission running
2 participants
@andchiind @oysand