Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DefaultLocalizationArea to deck #1003

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Add DefaultLocalizationArea to deck #1003

merged 2 commits into from
Sep 8, 2023

Conversation

oysand
Copy link
Contributor

@oysand oysand commented Sep 8, 2023

No description provided.

@oysand oysand linked an issue Sep 8, 2023 that may be closed by this pull request
Add default localization area to deck #996
Closed
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@oysand oysand force-pushed the add-default-localization-area-to-deck branch from 3ae41f6 to 911419b Compare September 8, 2023 06:45
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Sep 8, 2023
aeshub
aeshub requested changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@aeshub aeshub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@oysand oysand force-pushed the add-default-localization-area-to-deck branch from 41aa1ff to 3b49571 Compare September 8, 2023 08:01
@oysand oysand requested a review from aeshub September 8, 2023 08:02
@oysand oysand mentioned this pull request Sep 8, 2023
Closed
@aeshub aeshub added the improvement Improvement to existing functionality label Sep 8, 2023
@oysand oysand force-pushed the add-default-localization-area-to-deck branch from 3b49571 to 052d46f Compare September 8, 2023 08:35
@oysand
Copy link
Contributor Author

oysand commented Sep 8, 2023

/UpdateDatabase

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

👀 Running migration command... 👀

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

✨ Successfully ran migration command! ✨

@oysand oysand merged commit cbb4d51 into equinor:main Sep 8, 2023
9 checks passed
@oysand oysand deleted the add-default-localization-area-to-deck branch September 8, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeshub aeshub aeshub approved these changes

Assignees

@oysand oysand

Labels
database-change Will require migration improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add default localization area to deck
2 participants
@oysand @aeshub