Add LocalizationPose to Deck #987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔔 Changes in database folder detected 🔔 |
oysand
force-pushed
the
add-localization-pose-to-deck
branch
from
6f36e02 to
24afc0a
Compare
oysand
force-pushed
the
add-localization-pose-to-deck
branch
4 times, most recently
from
0d8a23e to
c31cdad
Compare
|
🔔 Migrations changes detected 🔔 |
Eddasol
reviewed
Aug 31, 2023
Comment on lines
403
to
+404
|
|
||
| }; |
Eddasol
reviewed
Aug 31, 2023
| @@ -144,7 +145,8 @@ private async Task<(string installationId, string plantId, string deckId, string | |||
| { | |||
| InstallationCode = installationCode, | |||
| PlantCode = plantCode, | |||
| Name = deckName | |||
| Name = deckName, | |||
| LocalizationPose = testPose | |||
There was a problem hiding this comment.
Area has DefaultLocalizationPose and deck has LocalizationPose. Consider renaming one of them for consistent naming
Eddasol
reviewed
Aug 31, 2023
Comment on lines
387
to
+388
| }; | ||
| var testLocalizationPose = new Pose |
There was a problem hiding this comment.
Suggested change
| }; | |
| var testLocalizationPose = new Pose | |
| }; | |
| var testLocalizationPose = new Pose |
Eddasol
reviewed
Aug 31, 2023
Comment on lines
387
to
+388
| }; | ||
| var testLocalizationPose = new Pose |
There was a problem hiding this comment.
Why not just use testPose instead of a separate testLocalizationPose? Alternatively, change area to also use testLocalizationPose and remove testPose
oysand
force-pushed
the
add-localization-pose-to-deck
branch
from
c31cdad to
ae73818
Compare
|
#1003 address this better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.