-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alert for failed requests #1018
Conversation
756ac79
to
03b52ba
Compare
Ideally I would like the banner alert to be triggered in ApiCaller.tsx, so that it's integrated in the event handler. Then we could neatly decide how each request should be handled in a single file. This is difficult though since BackendAPICaller is a static class which does not have access to custom contexts, and so we therefore need to update the banner in .catch statements where the BackendAPICaller is used. It would be possible to implement this custom error handler in ApiCaller.tsx if we made the custom class into a custom context instead though. |
bc1f4ca
to
4b9f942
Compare
As a part of implementing the alert in such a way that the dialog closes itself when an error is returned, I ended up refactoring MissionQueueView.tsx and the dialog component file. |
f08dd9d
to
6d16769
Compare
frontend/src/components/Pages/FrontPage/MissionOverview/MissionQueueView.tsx
Outdated
Show resolved
Hide resolved
0155a57
to
47d975e
Compare
47d975e
to
101e5c9
Compare
frontend/src/components/Pages/FrontPage/MissionOverview/MissionQueueView.tsx
Show resolved
Hide resolved
a8ef412
to
81a525e
Compare
d8b652a
to
24822ec
Compare
24822ec
to
e453c5e
Compare
4e4bded
to
8125894
Compare
fee2eb2
to
4c681df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
4c681df
to
b9afb98
Compare
Closes #1008