Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stop all robots button #1045

Merged
merged 22 commits into from
Nov 1, 2023
Merged

Add stop all robots button #1045

merged 22 commits into from
Nov 1, 2023

Conversation

mrica-equinor
Copy link
Contributor

No description provided.

@mrica-equinor mrica-equinor mentioned this pull request Oct 5, 2023
Closed
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@mrica-equinor mrica-equinor added feature New feature or request backend Backend related functionality frontend Frontend related functionality labels Oct 5, 2023
@mrica-equinor
Copy link
Contributor Author

In order to test the functionality atm it's necessary to add a safe position to an area and localize the robot in that area before clicking the stop all robots button. This will be addressed in another issue #1046

oysand
oysand requested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@mrica-equinor
Copy link
Contributor Author

mrica-equinor commented Oct 17, 2023 •
edited
Loading

Anyone knows why I am getting these errors ?

image

This has been solved by adding a return status 204 no content on the edpoints

@mrica-equinor
Copy link
Contributor Author

There's a bug, if you localize the robot in an area without safe zone it's crashing the backend. We should not merge this until it is fixed. I am not sure if this bug was introduced today or not but will fix it asap

@mrica-equinor mrica-equinor requested a review from oysand November 1, 2023 09:16
@mrica-equinor mrica-equinor force-pushed the new-stop-all-robots branch 2 times, most recently from 145edee to b48e4ba Compare November 1, 2023 12:43
oysand
oysand approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aeshub and others added 22 commits November 1, 2023 13:59
@aeshub @mrica-equinor
Add stop all button functionality
cd53b9b
@mrica-equinor
Add stop all robots backend endpoints
29e1295
@mrica-equinor
Add stop all button on frontend
38be124
@mrica-equinor
Move entityframework interactions to scoped service
9c884ac
@mrica-equinor
Fix dismiss robots from safe zone functionality
24b1886
@mrica-equinor
Add ongoing mission to queue in emergency state
092161b
@andchiind @mrica-equinor
Fix formatting
c7b8243
@andchiind @mrica-equinor
Update unit tests with new mocks and URLs
806d512
@andchiind @mrica-equinor
Remove excess comments and code
82bb719
@aeshub @mrica-equinor
Fix stop all robots button on the frontend
40ac3fe
@mrica-equinor
Improve dismiss robots from safe zones
aa8dc6b
@mrica-equinor
Add robot status chip for safe zone
40ad0b7
@mrica-equinor
Refactoring of the code
a8787bb
@andchiind @mrica-equinor
Add defaultlocalisationposeservice to tests
7de511d
@mrica-equinor
Improve code quality
dc0b8c4
@mrica-equinor
Simplfy Emergency Action Controller
20381a3
@mrica-equinor
Create Mission Scheduling Service
710b9fd
@mrica-equinor
Add MissionSchedulingService to event handler test
dd94a2d
@mrica-equinor
Improve add ongoing mission back to the queue
bee11f5
@mrica-equinor
Improve frontend when pressing the stop all button
206038d
@mrica-equinor
Add safe zone exception
682ec73
@mrica-equinor
Fix variable types for inspection overview
c503816
@mrica-equinor mrica-equinor merged commit 436e192 into equinor:main Nov 1, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eddasol Eddasol Eddasol left review comments

@andchiind andchiind andchiind left review comments

@aeshub aeshub aeshub left review comments

@oysand oysand oysand approved these changes

Assignees

@aeshub aeshub

@andchiind andchiind

@mrica-equinor mrica-equinor

Labels
backend Backend related functionality feature New feature or request frontend Frontend related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrica-equinor @aeshub @andchiind @oysand @Eddasol