Fix database entity detached issues on mission update

[aeshub]

No description provided.

[github-actions]

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

[andchiind]

This might be quite hard to do but would it maybe be possible to split away the change which fixes the database entity detached issue into a separate commit? Since currently it’s a bit hard to tell what changes are necessary in order to make sure the right context objects are used, and which changes were made to improve the code readability. No stress if the refactoring and fix are tightly coupled though.

[Eddasol]

LGTM :)

[aeshub]

This might be quite hard to do but would it maybe be possible to split away the change which fixes the database entity detached issue into a separate commit? Since currently it’s a bit hard to tell what changes are necessary in order to make sure the right context objects are used, and which changes were made to improve the code readability. No stress if the refactoring and fix are tightly coupled though.

The refactoring done in the second commit is basically the fix. So we wrap the different scoped services into a separate one so that we are not calling multiple different scoped services within the same event handler. So in a sense the second commit although it looks mostly like refactoring is the fix.