Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of Task.InspectionTarget #1362

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Remove use of Task.InspectionTarget #1362

merged 3 commits into from
Jan 30, 2024

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Jan 26, 2024 •
edited
Loading

  • Task.InspectionTarget should be removed as it is replaced by Inspection.InspectionTarget, but first existing custom missions needs to be adapted to the change. It will temporary be set to optional to allow removal in custom missions.
  • If a task has several inspections with different inspectionTargets, the current solution will display them all with the same task number in the mission map. Improvement for this can be solved as new issue.

@Eddasol Eddasol added bug Something isn't working backend Backend related functionality improvement Improvement to existing functionality frontend Frontend related functionality labels Jan 26, 2024
@Eddasol Eddasol self-assigned this Jan 26, 2024
@Eddasol Eddasol linked an issue Jan 26, 2024 that may be closed by this pull request
Frontend and backend uses different inspectiontargets #1353
Closed
@github-actions GitHub Actions
Copy link

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@Eddasol Eddasol force-pushed the frontend-insepction-target branch 4 times, most recently from 1c6b603 to 9d2de54 Compare January 26, 2024 11:42
@github-actions GitHub Actions
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Jan 26, 2024
@Eddasol Eddasol force-pushed the frontend-insepction-target branch 2 times, most recently from d500991 to a6e39c4 Compare January 26, 2024 12:00
andchiind
andchiind approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It could be good to have error handling if a certain version of ISAR requires an inspectionTarget, but it might also be worthwhile to do this in the respective ISAR implementations.

@Eddasol Eddasol force-pushed the frontend-insepction-target branch 2 times, most recently from e85e4da to 5937760 Compare January 30, 2024 07:36
@Eddasol Eddasol force-pushed the frontend-insepction-target branch from 5937760 to 5c4c334 Compare January 30, 2024 07:37
@Eddasol
Copy link
Contributor Author

Eddasol commented Jan 30, 2024

/UpdateDatabase

@github-actions GitHub Actions
Copy link

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

✨ Successfully ran migration command! ✨

@Eddasol Eddasol merged commit 919ac63 into equinor:main Jan 30, 2024
12 checks passed
@Eddasol Eddasol deleted the frontend-insepction-target branch January 30, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind approved these changes

Assignees

@Eddasol Eddasol

Labels
backend Backend related functionality bug Something isn't working database-change Will require migration frontend Frontend related functionality improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Frontend and backend uses different inspectiontargets
2 participants
@Eddasol @andchiind