Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple deprecated from robot status #1492

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Mar 22, 2024

No description provided.

@Eddasol Eddasol added backend Backend related functionality improvement Improvement to existing functionality labels Mar 22, 2024
@Eddasol Eddasol self-assigned this Mar 22, 2024
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Mar 22, 2024
@Eddasol Eddasol changed the title Deprecated sort Decouple deprecated from robot status Mar 22, 2024
@Eddasol Eddasol requested review from oysand and betaniat March 22, 2024 12:54
@Eddasol Eddasol force-pushed the deprecated-sort branch 3 times, most recently from 24a0cec to 31b22c1 Compare March 22, 2024 14:31
@Eddasol Eddasol linked an issue Mar 22, 2024 that may be closed by this pull request
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

backend/api/Database/Models/Robot.cs Show resolved Hide resolved
backend/api/Controllers/Models/CreateRobotQuery.cs Outdated Show resolved Hide resolved
@Eddasol Eddasol force-pushed the deprecated-sort branch 3 times, most recently from 5c6bc2d to ea26c1f Compare April 2, 2024 10:54
@Eddasol Eddasol requested a review from andchiind April 2, 2024 11:01
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eddasol
Copy link
Contributor Author

Eddasol commented Apr 2, 2024

/UpdateDatabase

Copy link

github-actions bot commented Apr 2, 2024

👀 Running migration command... 👀

Copy link

github-actions bot commented Apr 2, 2024

✨ Successfully ran migration command! ✨

@Eddasol Eddasol merged commit 98c7387 into equinor:main Apr 2, 2024
12 checks passed
@Eddasol Eddasol deleted the deprecated-sort branch April 2, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality database-change Will require migration improvement Improvement to existing functionality
Projects
None yet
2 participants