Decouple deprecated from robot status

backend/api.test/Client/MissionTests.cs

@@ -423,7 +423,6 @@ public async Task ScheduleDuplicateCustomMissionDefinitions()
                 SerialNumber = "GetNextRun",
                 RobotType = RobotType.Robot,
                 Status = RobotStatus.Available,
-                IsarConnected = true,
                 Host = "localhost",
                 Port = 3000,
                 CurrentInstallationCode = installationCode,
@@ -506,7 +505,6 @@ public async Task GetNextRun()
                 SerialNumber = "GetNextRun",
                 RobotType = RobotType.Robot,
                 Status = RobotStatus.Available,
-                IsarConnected = true,
                 Host = "localhost",
                 Port = 3000,
                 CurrentInstallationCode = installation.InstallationCode,
@@ -689,7 +687,6 @@ public async Task MissionDoesNotStartIfRobotIsNotInSameInstallationAsMission()
                 SerialNumber = "GetNextRun",
                 RobotType = RobotType.Robot,
                 Status = RobotStatus.Available,
-                IsarConnected = true,
                 Host = "localhost",
                 Port = 3000,
                 CurrentInstallationCode = otherInstallation.InstallationCode,
@@ -757,7 +754,6 @@ public async Task MissionFailsIfRobotIsNotInSameDeckAsMission()
                 SerialNumber = "GetMissionFailsIfRobotIsNotInSameDeckAsMission",
                 RobotType = RobotType.Robot,
                 Status = RobotStatus.Available,
-                IsarConnected = true,
                 Host = "localhost",
                 Port = 3000,
                 CurrentInstallationCode = installation.InstallationCode,

backend/api.test/Client/RobotTests.cs

@@ -116,7 +116,6 @@ public async Task RobotIsNotCreatedWithAreaNotInInstallation()
                 SerialNumber = "GetNextRun",
                 RobotType = RobotType.Robot,
                 Status = RobotStatus.Available,
-                IsarConnected = true,
                 Host = "localhost",
                 Port = 3000,
                 CurrentInstallationCode = wrongInstallation.InstallationCode,

backend/api.test/Database/DatabaseUtilities.cs

@@ -136,7 +136,6 @@ public async Task<Robot> NewRobot(RobotStatus status, Installation installation,
                 VideoStreams = new List<CreateVideoStreamQuery>(),
                 Host = "localhost",
                 Port = 3000,
-                IsarConnected = true,
                 Status = status
             };
 

backend/api.test/Services/RobotService.cs

@@ -109,7 +109,6 @@ public async Task Create()
                 RobotType = RobotType.Robot,
                 Host = "",
                 Port = 1,
-                IsarConnected = true,
                 Status = RobotStatus.Available
             };
 

backend/api/Controllers/Models/CreateRobotQuery.cs

@@ -22,8 +22,6 @@ public struct CreateRobotQuery
 
         public int Port { get; set; }
 
-        public bool IsarConnected { get; set; }
-
         public RobotStatus Status { get; set; }
     }
 }

backend/api/Controllers/Models/RobotResponse.cs

@@ -30,6 +30,8 @@ public class RobotResponse
 
         public bool IsarConnected { get; set; }
 
+        public bool Deprecated { get; set; }
+
         public bool MissionQueueFrozen { get; set; }
 
         public RobotStatus Status { get; set; }
@@ -60,6 +62,7 @@ public RobotResponse(Robot robot)
             Host = robot.Host;
             Port = robot.Port;
             IsarConnected = robot.IsarConnected;
+            Deprecated = robot.Deprecated;
             MissionQueueFrozen = robot.MissionQueueFrozen;
             Status = robot.Status;
             Pose = robot.Pose;

backend/api/Controllers/RobotController.cs

@@ -249,6 +249,54 @@ [FromBody] UpdateRobotQuery query
             }
         }
 
+        /// <summary>
+        ///     Updates deprecated field of a robot in the database
+        /// </summary>
+        /// <remarks>
+        /// </remarks>
+        /// <response code="200"> The robot was successfully updated </response>
+        /// <response code="404"> There was no robot with the given ID in the database </response>
+        [HttpPut]
+        [Authorize(Roles = Role.Admin)]
+        [Route("{id}/deprecated/{deprecated}")]
+        [ProducesResponseType(typeof(RobotResponse), StatusCodes.Status200OK)]
+        [ProducesResponseType(StatusCodes.Status400BadRequest)]
+        [ProducesResponseType(StatusCodes.Status401Unauthorized)]
+        [ProducesResponseType(StatusCodes.Status403Forbidden)]
+        [ProducesResponseType(StatusCodes.Status404NotFound)]
+        [ProducesResponseType(StatusCodes.Status500InternalServerError)]
+        public async Task<ActionResult<RobotResponse>> UpdateRobotDeprecated(
+            [FromRoute] string id,
+            [FromRoute] bool deprecated
+        )
+        {
+            logger.LogInformation("Updating deprecated on robot with id={Id} to deprecated={Deprecated}", id, deprecated);
+
+            try
+            {
+                var robot = await robotService.ReadById(id);
+                if (robot == null)
+                {
+                    string errorMessage = $"No robot with id: {id} could be found";
+                    logger.LogError("{Message}", errorMessage);
+                    return NotFound(errorMessage);
+                }
+
+                Robot updatedRobot;
+                updatedRobot = await robotService.UpdateDeprecated(id, deprecated);
+
+                var robotResponse = new RobotResponse(updatedRobot);
+                logger.LogInformation("Successful updated deprecated on robot to database");
+
+                return Ok(robotResponse);
+            }
+            catch (Exception e)
+            {
+                logger.LogError(e, "Error while updating robot with id={Id}", id);
+                throw;
+            }
+        }
+
         /// <summary>
         ///     Deletes the robot with the specified id from the database
         /// </summary>
@@ -590,6 +638,14 @@ [FromRoute] string armPosition
                 logger.LogWarning("{Message}", errorMessage);
                 return Conflict(errorMessage);
             }
+
+            if (robot.Deprecated)
+            {
+                string errorMessage = $"Robot {robotId} is deprecated ({robot.Status}) and cannot run missions";
+                logger.LogWarning("{Message}", errorMessage);
+                return Conflict(errorMessage);
+            }
+
             try { await isarService.StartMoveArm(robot, armPosition); }
             catch (HttpRequestException e)
             {

backend/api/Database/Context/InitDb.cs

@@ -283,7 +283,6 @@ private static List<Robot> GetRobots()
                 Name = "R2-D2",
                 SerialNumber = "D2",
                 Status = RobotStatus.Available,
-                IsarConnected = true,
                 Host = "localhost",
                 Port = 3000,
                 CurrentInstallation = installations[0],
@@ -298,7 +297,6 @@ private static List<Robot> GetRobots()
                 IsarId = "c68b679d-308b-460f-9fe0-87eaadbd1234",
                 SerialNumber = "SS79",
                 Status = RobotStatus.Busy,
-                IsarConnected = true,
                 Host = "localhost",
                 Port = 3000,
                 CurrentInstallation = installations[0],
@@ -312,7 +310,6 @@ private static List<Robot> GetRobots()
                 IsarId = "c68b679d-308b-460f-9fe0-87eaadbd5678",
                 SerialNumber = "Earth616",
                 Status = RobotStatus.Available,
-                IsarConnected = true,
                 Host = "localhost",
                 Port = 3000,
                 CurrentInstallation = installations[0],

backend/api/Database/Models/Robot.cs

@@ -13,7 +13,8 @@ public Robot()
             Name = "defaultId";
             SerialNumber = "defaultSerialNumber";
             Status = RobotStatus.Offline;
-            IsarConnected = false;
+            IsarConnected = true;
+            Deprecated = false;
             Host = "localhost";
             Port = 3000;
             Pose = new Pose();
@@ -41,7 +42,8 @@ public Robot(CreateRobotQuery createQuery, Installation installation, Area? area
             VideoStreams = videoStreams;
             Host = createQuery.Host;
             Port = createQuery.Port;
-            IsarConnected = createQuery.IsarConnected;
+            IsarConnected = true;
+            Deprecated = false;
             Status = createQuery.Status;
             Pose = new Pose();
         }
@@ -95,6 +97,9 @@ public bool IsRobotBatteryLevelHighEnoughToStartMissions()
         [Required]
         public bool IsarConnected { get; set; }
 
+        [Required]
+        public bool Deprecated { get; set; }
+
         [Required]
         public bool MissionQueueFrozen { get; set; }
 
@@ -128,6 +133,5 @@ public enum RobotStatus
         Busy,
         Offline,
         Blocked,
-        Deprecated
     }
 }

backend/api/EventHandlers/MqttEventHandler.cs

@@ -129,7 +129,6 @@ private async void OnIsarRobotInfo(object? sender, MqttReceivedArgs mqttArgs)
                         Host = isarRobotInfo.Host,
                         Port = isarRobotInfo.Port,
                         Status = RobotStatus.Available,
-                        IsarConnected = true
                     };
 
                     var newRobot = await robotService.CreateFromQuery(robotQuery);