Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused IsarStep topic #1870

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Remove unused IsarStep topic #1870

merged 1 commit into from
Dec 13, 2024

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Dec 11, 2024 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@Eddasol Eddasol added the improvement Improvement to existing functionality label Dec 11, 2024
@Eddasol Eddasol self-assigned this Dec 11, 2024
@Eddasol Eddasol marked this pull request as ready for review December 11, 2024 14:57
eivindsjovold
eivindsjovold requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@eivindsjovold eivindsjovold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-run snyk checks

@Eddasol Eddasol force-pushed the remove-step branch 3 times, most recently from 7c5b246 to 2d29ac2 Compare December 13, 2024 08:02
@Eddasol Eddasol merged commit 008ae6a into equinor:main Dec 13, 2024
12 checks passed
@Eddasol Eddasol deleted the remove-step branch December 13, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eivindsjovold eivindsjovold eivindsjovold approved these changes

@mrica-equinor mrica-equinor Awaiting requested review from mrica-equinor

Assignees

@Eddasol Eddasol

Labels
improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eddasol @eivindsjovold