Refactor/replace black flake8 with ruff #359
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruff thought that the imports in context were unused.
1 task
Not sure if this solves the error, I have renamed the file locally, but for some reason it doesn't propagate to GH
rwiker
reviewed
Dec 17, 2024
| @@ -255,16 +255,16 @@ the ``has`` filter to find cases that have ``4d-seismic`` data: | |||
|
|
|||
| .. code-block:: python | |||
|
|
|||
| from fmu.sumo.explorer import Explorer, Filters | |||
| from fmu.sumo.explorer import Explorer, filters | |||
There was a problem hiding this comment.
Why is Filters changed to filters here?
There was a problem hiding this comment.
I guess the convention is lowercase filenames? Which Filters.py is breaking.
Should Filters.py be renamed to filters.py as well?
There was a problem hiding this comment.
Oops. I thought I had renamed the file to filters.py.
rwiker
previously approved these changes
Dec 17, 2024
pep-8 recommends the use of Since the naming of all the other files in the same folder is using snake_case I'll maintain that convention by renaming the file to filters.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#358
Short description
Pre-review checklist
print()statements, commented-out code, or other remnants from the development. 👀Pre-merge checklist