-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/replace black flake8 with ruff #359
Open
sean-sinclair
wants to merge
8
commits into
main
Choose a base branch
from
refactor/replace-black-flake8-with-ruff
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
99e5527
build(pyproject): replaced black and flake8 with ruff
sean-sinclair a697d22
style: applied automatic Ruff linting and formatting
sean-sinclair d86bba1
style: Manual fixes of ruff linting results
sean-sinclair 6cd98f9
ci: Linting and formatting on pull request
sean-sinclair 5d40858
chore(pre-commit): Linting and Formatting runs on pre-commit and pre-…
sean-sinclair 89644c3
fix: Tests failing due to missing imports
sean-sinclair 4a9eb5c
fix: noqa on pep-8 naming for filters
sean-sinclair 536f5d4
chore: rename filters and add class def
sean-sinclair File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
name: Check formatting and linting | ||
|
||
on: | ||
pull_request: | ||
push: { branches: [main] } | ||
|
||
jobs: | ||
ruff-check: | ||
name: Run ruff lint and format checks | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- uses: actions/setup-python@v5 | ||
with: | ||
python-version: '3.11' | ||
cache: 'pip' | ||
|
||
- name: Installing dependencies | ||
run: pip install ruff | ||
|
||
- name: Run ruff lint | ||
run: ruff check . | ||
|
||
- name: Run ruff format | ||
run: ruff format . --check | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
repos: | ||
- repo: local | ||
hooks: | ||
- id: lint | ||
name: Ruff Lint | ||
description: Linting using ruff | ||
entry: bash -c 'ruff check .' | ||
language: system | ||
stages: ["pre-commit", "pre-push"] | ||
|
||
- id: format | ||
name: Ruff Format | ||
description: Formatting using ruff | ||
entry: bash -c 'ruff format . --check' | ||
language: system | ||
stages: ["pre-commit", "pre-push"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is
Filters
changed tofilters
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the convention is lowercase filenames? Which
Filters.py
is breaking.Should
Filters.py
be renamed tofilters.py
as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. I thought I had renamed the file to filters.py.