Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaml file types for linting and validation #391

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

jonathan-eq
Copy link
Collaborator

@jonathan-eq jonathan-eq commented Sep 5, 2023

Added yaml files to mainly use with argsparser for releasefile, upgrade_proposals, repository_file, package_status_file, and package_maturity

Resolves #383
Resolves #382

@jonathan-eq jonathan-eq force-pushed the test-yaml-dont-delete-old branch from 36ee5ad to 6f5907d Compare September 5, 2023 13:41
@jonathan-eq jonathan-eq changed the title add-yaml-file-types-for-linting-and-validation Add yaml file types for linting and validation Sep 5, 2023
@jonathan-eq jonathan-eq self-assigned this Sep 5, 2023
@berland
Copy link
Contributor

berland commented Sep 7, 2023

Split the file rename into two commits, one just doing the filename change, and then a commit that edits it (and the other file edits)

komodo/yaml_file_type.py Outdated Show resolved Hide resolved
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

halfway through :)

komodo/yaml_file_type.py Outdated Show resolved Hide resolved
komodo/yaml_file_type.py Outdated Show resolved Hide resolved
komodo/yaml_file_type.py Outdated Show resolved Hide resolved
komodo/yaml_file_type.py Outdated Show resolved Hide resolved
komodo/yaml_file_type.py Outdated Show resolved Hide resolved
komodo/yaml_file_type.py Outdated Show resolved Hide resolved
komodo/yaml_file_type.py Outdated Show resolved Hide resolved
komodo/yaml_file_type.py Outdated Show resolved Hide resolved
komodo/yaml_file_type.py Outdated Show resolved Hide resolved
komodo/yaml_file_type.py Outdated Show resolved Hide resolved
komodo/yaml_file_types.py Outdated Show resolved Hide resolved
komodo/yaml_file_types.py Outdated Show resolved Hide resolved
komodo/yaml_file_types.py Outdated Show resolved Hide resolved
komodo/yaml_file_types.py Outdated Show resolved Hide resolved
@berland
Copy link
Contributor

berland commented Sep 18, 2023

Are the tests for this PR inside PR #388? The tests related to the changes in this PR should be cherry-picked into this PR.

@jonathan-eq jonathan-eq force-pushed the test-yaml-dont-delete-old branch 3 times, most recently from 0197679 to ea6693e Compare September 19, 2023 07:39
@jonathan-eq jonathan-eq force-pushed the test-yaml-dont-delete-old branch from 332b8e3 to a32e9fa Compare September 19, 2023 12:55
Added yaml files to mainly use with argsparser for releasefile, upgrade_proposals, repository_file, package_status_file, and package_maturity
@jonathan-eq jonathan-eq force-pushed the test-yaml-dont-delete-old branch from a32e9fa to 1af27e6 Compare September 20, 2023 10:15
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the perserverence, lets ship 🚢

@jonathan-eq jonathan-eq merged commit 46ea9b4 into equinor:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make entry of repository.yaml should be validated earlier Package case style causes problems
2 participants