Skip to content

[DRAFT] refactor/SMA: Inheritable Account Refactor #552

[DRAFT] refactor/SMA: Inheritable Account Refactor

[DRAFT] refactor/SMA: Inheritable Account Refactor #552

Triggered via pull request August 7, 2024 02:23
Status Failure
Total duration 3m 6s
Artifacts

test.yml

on: pull_request
Run Linters
24s
Run Linters
Run Forge Tests (optimized-test-deep)
2m 55s
Run Forge Tests (optimized-test-deep)
Run Forge Tests (default)
45s
Run Forge Tests (default)
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 6 warnings
Run Linters: src/account/AccountFactory.sol#L115
'_getAddressFallbackSigner' should not start with _
Run Linters: src/account/SemiModularAccount.sol#L10
imported name IModuleManager is not used
Run Linters: src/account/SemiModularAccount.sol#L11
imported name IValidation is not used
Run Linters
Process completed with exit code 1.
Run Forge Tests (optimized-test-deep)
Process completed with exit code 1.
Run Linters
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, pnpm/action-setup@v2, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Linters: src/account/AccountFactory.sol#L115
Function order is incorrect, public view function can not go after public pure function (line 111)
Run Linters: src/account/SemiModularAccount.sol#L51
Function order is incorrect, internal function can not go after internal view function (line 35)
Run Linters: src/account/UpgradeableModularAccount.sol#L364
Function order is incorrect, public view function can not go after internal view function (line 340)
Run Forge Tests (default)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Forge Tests (optimized-test-deep)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/