Fix: update interfaces and add validation behavior to spec #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangting-alchemy
force-pushed
the
fangting/spec
branch
from
a38a130 to
bd8b02b
Compare
adamegyed
reviewed
Aug 15, 2024
standard/ERCs/erc-6900.md
Outdated
| external | ||
| returns (uint256); | ||
|
|
||
| /// @notice Run the pre runtime validation hook specified by the `entityId`. | ||
| /// @notice Run the runtime validationFunction specified by the `entityId`. |
There was a problem hiding this comment.
Should we prefer to spell it out as "validation function" instead of the condensed "validationFunction"?
There was a problem hiding this comment.
we should. Updated all the refs in comments and docs.
fangting-alchemy
force-pushed
the
fangting/spec
branch
2 times, most recently
from
83dc7b1 to
44e77a7
Compare
fangting-alchemy
force-pushed
the
fangting/spec
branch
from
44e77a7 to
e70fc41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.