Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address compiler warnings #149

Merged
merged 1 commit into from
Aug 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/account/SemiModularAccount.sol
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,6 @@ contract SemiModularAccount is UpgradeableModularAccount {

constructor(IEntryPoint anEntryPoint) UpgradeableModularAccount(anEntryPoint) {}

/// Override reverts on initialization, effectively disabling the initializer.
function initializeWithValidation(ValidationConfig, bytes4[] calldata, bytes calldata, bytes[] calldata)
external
override
initializer
{
revert InitializerDisabled();
}

/// @notice Updates the fallback signer address in storage.
/// @dev This function causes the fallback signer getter to ignore the bytecode signer if it is nonzero. It can
/// also be used to revert back to the bytecode signer by setting to zero.
Expand Down Expand Up @@ -83,6 +74,15 @@ contract SemiModularAccount is UpgradeableModularAccount {
return _retrieveFallbackSignerUnchecked(_getSemiModularAccountStorage());
}

/// Override reverts on initialization, effectively disabling the initializer.
function initializeWithValidation(ValidationConfig, bytes4[] calldata, bytes calldata, bytes[] calldata)
external
pure
override
{
revert InitializerDisabled();
}

function _execUserOpValidation(
ModuleEntity userOpValidationFunction,
PackedUserOperation memory userOp,
Expand Down
1 change: 1 addition & 0 deletions test/account/DirectCallsFromModule.t.sol
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.19;

import {UpgradeableModularAccount} from "../../src/account/UpgradeableModularAccount.sol";
Expand Down
Loading