Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address compiler warnings #149

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix: address compiler warnings #149

merged 1 commit into from
Aug 21, 2024

Conversation

adamegyed
Copy link
Contributor

Motivation

We have two small compiler warnings in our current code on develop:

  • SPDX license identifier not provided in source file. ... in DirectCallsFromModule.t.sol
  • Warning (5740): Unreachable code.
      --> src/account/AccountStorageInitializable.sol:49:9:
       |
    49 |         if (isTopLevelCall) {
       |         ^ (Relevant source part starts here and spans across multiple lines).
    

Solution

Add an SPDX identifier to the test file.

Remove the initializer modifier from the overwritten initializer function in SemiModularAccount, and reorder functions due to the new pure visibility.

@adamegyed adamegyed requested a review from Zer0dot August 20, 2024 23:17
Copy link
Contributor

@Zer0dot Zer0dot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@adamegyed adamegyed merged commit 9d3aad7 into develop Aug 21, 2024
3 checks passed
@adamegyed adamegyed deleted the adam/cleanup-compiler branch August 21, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants