Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle object files with .*.o patterns when running Linker Script Generator (IDFGH-11962) #13039

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

valeros
Copy link
Contributor

@valeros valeros commented Jan 23, 2024

Currently, only .o, .*.obj and .obj patterns are taken into account. It would be great to have object files with the .*.o extension pattern (e.g. file.cpp.o) also processed as they're quite widespread in third-party integrations.

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Jan 23, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello valeros, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against bd56ca4

@espressif-bot espressif-bot added the Status: Opened Issue is new label Jan 23, 2024
@github-actions github-actions bot changed the title Handle object files with .*.o patterns when running Linker Script Generator Handle object files with .*.o patterns when running Linker Script Generator (IDFGH-11962) Jan 23, 2024
Currently, only `.o`, `.*.obj` and `.obj` patterns
are taken into account. It would be great to have
object files with the `.*.o` extension pattern
(e.g. `file.cpp.o`) also processed as they're quite
widespread in third-party integrations.
@0xjakob
Copy link
Contributor

0xjakob commented Jan 25, 2024

sha=bd56ca48be81763872d1562822b94843eed12fdc

@0xjakob 0xjakob added the PR-Sync-Merge Pull request sync as merge commit label Jan 25, 2024
@espressif-bot espressif-bot added Status: In Progress Work is in progress Status: Reviewing Issue is being reviewed and removed Status: Opened Issue is new Status: In Progress Work is in progress labels Jan 25, 2024
@0xjakob
Copy link
Contributor

0xjakob commented Jan 25, 2024

@valeros We plan to merge this, thanks for the fix! After merging this internally, it'll appear on master, soon.

@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Reviewing Issue is being reviewed labels Jan 26, 2024
@espressif-bot espressif-bot merged commit bd56ca4 into espressif:master Feb 4, 2024
8 checks passed
@valeros valeros deleted the patch-1 branch February 5, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants