Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude empty requests in requests list #3998

Merged
merged 17 commits into from
Nov 22, 2024
Merged

Exclude empty requests in requests list #3998

merged 17 commits into from
Nov 22, 2024
+234 −29

Commits on Oct 29, 2024

  1. Exclude empty requests in requests list

    @jtraglia
    jtraglia committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    0c5a136 View commit details
    Browse the repository at this point in the history

  2. Fix table of contents

    @jtraglia
    jtraglia committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    369b7e5 View commit details
    Browse the repository at this point in the history

  3. Use assert instead of raise

    @jtraglia
    jtraglia committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2bd570c View commit details
    Browse the repository at this point in the history

  4. Fix indentation

    @jtraglia
    jtraglia committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8a8a321 View commit details
    Browse the repository at this point in the history

  5. Simplify get_execution_requests

    @jtraglia
    jtraglia committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3ce2929 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Check for ascending order

    @jtraglia
    jtraglia committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    4438166 View commit details
    Browse the repository at this point in the history

  2. Fix typo 

    Co-authored-by: Alex Stokes <[email protected]>
    @jtraglia @ralexstokes
    jtraglia and ralexstokes authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e90c792 View commit details
    Browse the repository at this point in the history

  3. Apply other stokes suggestion

    @jtraglia
    jtraglia committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    b3e77d2 View commit details
    Browse the repository at this point in the history

  4. Use less python sugar

    @jtraglia
    jtraglia committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    276c562 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Replace assert messages with comments

    @jtraglia
    jtraglia committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ebbce03 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Include requests_root in block_hash computation

    @jtraglia
    jtraglia committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    e472afd View commit details
    Browse the repository at this point in the history

  2. Add comment to compute_requests_hash

    @jtraglia
    jtraglia committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    b1c9d27 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Fix block hash computation for deposit transition tests 

    Request hash is not considered in `compute_el_block_hash`, have to use
one of the other overloads for this to work.
    @etan-status
    etan-status committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    de52c76 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Merge pull request #1 from etan-status/exclude-empty-requests 

    Fix block hash computation for deposit transition tests
    @jtraglia
    jtraglia authored Nov 22, 2024
    Configuration menu
    Copy the full SHA
    36b4979 View commit details
    Browse the repository at this point in the history

  2. Fix block hash computation for withdrawal sanity tests 

    Request hash is not considered in `compute_el_block_hash`, have to use
one of the other overloads for this to work.
    @etan-status
    etan-status committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    15e3f15 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #2 from etan-status/exclude-empty-requests

    @jtraglia
    jtraglia authored Nov 22, 2024
    Configuration menu
    Copy the full SHA
    bfe166c View commit details
    Browse the repository at this point in the history

  4. Rename requests_root to requests_hash

    @jtraglia
    jtraglia committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    4aad8eb View commit details
    Browse the repository at this point in the history