Migrate Banner Notification to Typescript #6543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add typed props and style for the banner notification and switch from js file to typescript react component Refs: ethereum#6392
Mousticke
requested review from
samajammin,
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
Mousticke
changed the title
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 29m PerformanceLighthouse report
|
pettinarip
approved these changes
Jun 3, 2022
|
@all-contributors please add @Mousticke for code |
|
I've put up a pull request to add @Mousticke! 🎉 |
|
@Mousticke be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. And we've just released our 2022 POAPs so remember to claim yours also 🥳! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate
BannerNotificationcomponent from js to tsxRelated Issue
Related to Epic: TypeScript rollout