Epic: TypeScript rollout #6392
Comments
|
Hi there, I would like to be assigned to these two components :
Thnak you very much |
|
Hey @Mousticke thanks for getting involved. As I mentioned in the Discord chat, I have assigned |
add typed props and style for the banner notification and switch from js file to typescript react component Refs: ethereum#6392
|
@pettinarip : After the #6543 PR is made, I'd like to migrate:
Thank you :) |
Assigned! @Mousticke
|
add typed props and style for the accordion and switch from js file to typescript react component Refs: ethereum#6392
add typed props for the card list and switch from js file to typescript react component Refs: ethereum#6392
isPageIncomplete variable is truthy or falsy but the banner notification component accept a boolean props. So we convert truthy or falsy to true or false Refs: ethereum#6392
|
src/pages/layer-2.js I would like to work on this @pettinarip |
the card list components has been migrated to typescript react component. For a given card list item, if the image is provided, then the alt props must be passed as GastbyImage requires the alt props Refs: ethereum#6392
|
@adi44 assigned! and thanks! |
for typescript development, we migrate all javascript files to ts. Refs: ethereum#6392
|
Hi @pettinarip |
|
May I please convert the existing JS scripts to TS and make them work using |
Sorry @Mousticke, that file was already assigned, we had forgotten to put the handle next to it. |
Good call @SNikhill are you talking about |
|
@pettinarip the component |
|
Good call @Mousticke, updated. |
|
@adi44 @andyGallagher Hey folks, as we are getting closed to finishing with the migration I wanted to touch base with you regarding the migration of the files that were assigned to you. I want to know if you are still planning on migrating them. If not, I can tackle them now and close the issue. |
|
Yeah.i couldnt do it on time
On Thu, 21 Jul 2022 at 9:41 PM, Pablo Pettinari ***@***.***> wrote:
@adi44 <https://github.com/adi44> @andyGallagher
<https://github.com/andyGallagher> Hey folks, as we are getting closed to
finishing with the migration I wanted to touch base with you regarding the
migration of the files that were assigned to you. I want to know if you are
still planning on migrating them. If not, I can tackle them now and close
the issue.
—
Reply to this email directly, view it on GitHub
<#6392 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHPNRBY6FYWWTE6UIKRWYBTVVFZD5ANCNFSM5WJRVC4A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Sent from my Iphone
|
Thanks @adi44 |
|
I was migrating the script to Typescript and was wondering why I noticed that noImplicitAny was set to I wanted to verify if this was intentional to make the migration ease as this flag can give one a feeling of a correct TypeScript file even though it ain't. -- I am setting it to |
|
Sorry, I read the |
Yes, exactly @SNikhill. I try to that myself to avoid |
|
...and we are done! thanks to everyone who has contributed. Amazing job 🚀 |
This is an epic that makes up part of the ethereum.org Q2 roadmap
Description
Our codebase is rapidly increasing in size and in contributors. This brings challenges to reliably keep the code organized, avoid code duplication, and review code.
To help alleviate these challenges, we’ll be incorporating TypeScript into our codebase. We believe having a strongly typed language will reduce bugs, improve code quality, increase productivity and allow us to scale (both our codebase and our developer community) better in the long term.
This effort also pairs closely with implementing a UI library. Many UI library come with TypeScript support, which is worth taking advantage of.
Todo
How to contribute
This file is going to serve as a centralized ledger 🤪 to keep track of each
jsfile that needs to be migrated.If you’d like to help with this migration, please follow these steps:
📒 Complete list of
jsfiles to migratesrc/components/WalletCard.js @Moustickesrc/components/WalletCompare.js @Moustickesrc/data/CreateWallet.js @vdusartThe text was updated successfully, but these errors were encountered: