-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement emotion & chakra #7179
Conversation
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 13m |
Looks great overall @pettinarip! Noticed a few small styling issues:
Spacing of content on docs pages looks off: Most product pages look great but there's some slight differences in spacing / header font size on some pages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Some minor styling issues & some documentation updates needed.
Styling changes here look to be fixed in this PR: #7195 |
// set isDarkTheme based on browser/app user preferences | ||
useEffect(() => { | ||
if (localStorage && localStorage.getItem("dark-theme") !== null) { | ||
setIsDarkTheme(localStorage.getItem("dark-theme") === "true") | ||
} else { | ||
setIsDarkTheme(window.matchMedia("(prefers-color-scheme: dark)").matches) | ||
} | ||
}, []) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pettinarip So am I correct the users browser preference will still be accounted for here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we are using this flag useSystemColorMode
for that. More on this here: https://chakra-ui.com/docs/styled-system/color-mode#updating-the-theme-config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Nice job @pettinarip!
Exciting! 😄 |
Description
The first step towards adopting Chakra UI is to migrate from
styled-components
toemotion
.UPDATE: chakra PR was merged #7195 now this PR includes chakra + emotion setup.
Related Issue
Epic #6374
Fixes #7054