Chakra UI setup #7195
Merged
Chakra UI setup #7195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
content 🖋️
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 33m |
pettinarip
force-pushed
the
chakra-setup
branch
from
956c758 to
b0a1ab6
Compare
pettinarip
requested review from
samajammin,
wackerow,
corwintines,
minimalsm and
jmcook1186
as code owners
samajammin
reviewed
Aug 3, 2022
| @@ -0,0 +1,12 @@ | |||
| const styles = { | |||
| global: (_props) => ({ | |||
| // TODO: remove these overrides as we adopt the new Design System | |||
There was a problem hiding this comment.
A bit more documentation/context on why this is needed to begin with would be helpful.
There was a problem hiding this comment.
e.g. why is both this file & GlobalStyle.tsx needed?
corwintines
reviewed
Aug 4, 2022
| const config: ThemeConfig = { | ||
| cssVarPrefix: "eth", | ||
| initialColorMode: "light", | ||
| useSystemColorMode: false, |
There was a problem hiding this comment.
I think we should use the system color mode personally, I enjoy this feature when I use websites.
There was a problem hiding this comment.
Agreed. I've changed it 👍🏼
corwintines
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: branched off from #7179 (depends on
emotion)Description
Initial Chakra UI setup.
Things addressed in this PR:
GlobalStylecomponentRelated Issue
Epic #6374
Fixes #7196