Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation Program page revamp #7289

Merged
merged 22 commits into from
Aug 15, 2022
Merged

Translation Program page revamp #7289

merged 22 commits into from
Aug 15, 2022

Conversation

lukassim
Copy link
Contributor

@lukassim lukassim commented Aug 3, 2022 •
edited by samajammin
Loading

Description

  • Revamp Translation Program page and link out to all subpages
  • Create How to translate subpage
  • Create Blog translations subpage
  • Create Launchpad translations subpage
  • Create Mission & vision subpage
  • Create Resources subpage
  • Remove "In-progress translations" section

Preview deploy:
https://ethereumorgwebsitedev01-translationprogramsubpages.gtsb.io/en/contributing/translation-program/

Related Issue

#7206

@lukassim lukassim added feature ✨ This is enhancing something existing or creating something new translation 🌍 This is related to our Translation Program epic 💪 This issue is an epic on our product roadmap labels Aug 3, 2022
@lukassim lukassim self-assigned this Aug 3, 2022
@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 labels Aug 3, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 3, 2022 •
edited
Loading

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 29m

@samajammin samajammin force-pushed the translation-program-subpages branch from a02d40d to 2588b1b Compare August 3, 2022 21:19
@samajammin
Copy link
Member

FYI @lukassim I had to rebase this branch with dev in order to remove the "In-progress translations" section (to pull in the TypeScript file).

You'll want to run git reset --hard origin/translation-program-subpages before making any changes locally.

samajammin
samajammin reviewed Aug 3, 2022
View reviewed changes
src/content/contributing/translation-program/index.md

Don't see your language listed? [Open an issue](https://github.com/ethereum/ethereum-org-website/issues/new/choose) or ask in our [Discord](https://discord.gg/6WX7E97)
#### Ethereum.org {#ethereumorg}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I added this "ethereum.org" section - I think it's worth re-iterating this is one of the projects we work on.

I also added a description of each project, which I encourage edits on :)

@samajammin samajammin marked this pull request as ready for review August 3, 2022 21:43
samajammin
samajammin reviewed Aug 3, 2022
View reviewed changes
src/content/contributing/translation-program/index.md

**_1 – Left sidebar_**
- Visit the [Launchpad translations page](/contributing/translation-program/launchpad-translations/)
- Join the [Launchpad translations project in Crowdin](https://crowdin.com/project/ethereum-staking-launchpad)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Join the [Launchpad translations project in Crowdin](https://crowdin.com/project/ethereum-staking-launchpad)
- Join the [Launchpad translations project in Crowdin](https://crowdin.com/project/ethereum-staking-launchpad/invite)

Should all Crowdin project links go to the /invite page? I'd think so...

samajammin
samajammin reviewed Aug 3, 2022
View reviewed changes
src/content/contributing/translation-program/index.md
The main translation area – source text is displayed on top, with additional context and screenshots, if available.
To suggest a new translation, enter your translation in the ‘’Enter translation here’’ field and click Save.
- Visit the [Blog translations page](/contributing/translation-program/blog-translations/)
- Join the [Blog translations project in Crowdin](https://crowdin.com/project/ethereum-foundation-blog)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Join the [Blog translations project in Crowdin](https://crowdin.com/project/ethereum-foundation-blog)
- Join the [Blog translations project in Crowdin](https://crowdin.com/project/ethereum-foundation-blog/invite)

@minimalsm
Copy link
Contributor

Build timed out, rebuilding 😠

@corwintines corwintines merged commit 140c182 into dev Aug 15, 2022
@corwintines corwintines deleted the translation-program-subpages branch August 15, 2022 20:52
@corwintines corwintines mentioned this pull request Aug 15, 2022
Merged
@konopkja
Copy link
Contributor

@lukassim @samajammin @minimalsm I dont see any specific section related to rewards (certificates, poaps..). There is a small banner mentioning POAPs but thats not enough in my opinion. I think this topic deserves its own section where certificates are also mentioned and poaps explained what it is. (not everyone will know). What are your opinions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konopkja konopkja konopkja left review comments

@samajammin samajammin samajammin left review comments

@minimalsm minimalsm minimalsm approved these changes

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@jmcook1186 jmcook1186 Awaiting requested review from jmcook1186

Assignees

@lukassim lukassim

Labels
content 🖋️ This involves copy additions or edits epic 💪 This issue is an epic on our product roadmap feature ✨ This is enhancing something existing or creating something new translation 🌍 This is related to our Translation Program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lukassim @samajammin @minimalsm @konopkja @corwintines