Migrate AssetDownload.tsx component to Chakra
#9103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlazzero
requested review from
samajammin,
wackerow,
corwintines,
pettinarip,
minimalsm and
jmcook1186
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
pettinarip
requested changes
Jan 18, 2023
There was a problem hiding this comment.
Good job @benlazzero thanks for the PR! 💪🏼
The overall result looks great. I've left a few minor comments and a question about the using of the Container component.
Co-authored-by: Pablo Pettinari <[email protected]>
Co-authored-by: Pablo Pettinari <[email protected]>
Co-authored-by: Pablo Pettinari <[email protected]>
Co-authored-by: Pablo Pettinari <[email protected]>
Co-authored-by: Pablo Pettinari <[email protected]>
|
Thanks glad to help! Tbh thinking back to when I wrote the code I wasn't all that sure about those differences. All the changes make total sense. |
pettinarip
approved these changes
Jan 18, 2023
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
80 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the
AssetDownload.tsxcomponent to Chakra#6374
First migration I've done, I am happy to implement any change requests!