Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Implement UI library #6374

Closed
80 tasks done
pettinarip opened this issue May 17, 2022 · 134 comments · Fixed by #10575
Closed
80 tasks done

Epic: Implement UI library #6374

pettinarip opened this issue May 17, 2022 · 134 comments · Fixed by #10575
Assignees
Labels
epic 💪 This issue is an epic on our product roadmap Status: In Progress Work is in progress

Comments

@pettinarip
Copy link
Member

pettinarip commented May 17, 2022

This is an epic that makes up part of the ethereum.org Q3 roadmap

Description

A major insight from our research into accessibility and our website audits last quarter was that many of the issues we face, like lack of keyboard navigation, support for assistive technology and consistent W3C design patterns can be solved out-of-the-box by adopting an open source UI library.

Ultimately we’ve come to believe that rolling our own robust components is not what we should focus our time on. Leveraging an existing UI library will save our development and design team time to focus more energy on what matters - shipping products for our Ethereum users. This effort also ties in well with our work on the open design system and will serve as the foundation to our component library.

Todo

How to contribute

If you’d like to help with this migration, please follow these steps:

  1. Leave a comment here asking which file you would want to work on.
  2. We assign you to the file (by adding your handle next to the file name in the list).
    • Read and follow our UI migration guide for some tips & guidance.
    • If you were assigned to multiple files then create a separate PR for each component. It will make the testing process much simpler and more organized.
  3. Once you finish it (PR merged), we’ll mark it as done.
  4. Repeat!

First wave (completed)
@pettinarip pettinarip added the epic 💪 This issue is an epic on our product roadmap label May 17, 2022
@pettinarip pettinarip self-assigned this May 17, 2022
@MahendraBishnoi29
Copy link
Contributor

can i contribute?

@samajammin samajammin added the Status: Up Next This issue has been prioritized to work on soon label Jul 14, 2022
This was referenced Jul 25, 2022
@nikkhielseath
Copy link
Contributor

Is there going to be a list of the components that are to be ported over?

@pettinarip
Copy link
Member Author

Is there going to be a list of the components that are to be ported over?

Yes! we are preparing the ground for that. I'll update this same issue with the list of files soon (~this week) & will let you know.

@nikkhielseath
Copy link
Contributor

@pettinarip
May I please have the 4 A's?
image

@Mousticke
Copy link
Contributor

Mousticke commented Sep 6, 2022

@pettinarip
Let's go for the B's

  • BannerNotification.tsx
  • BoxGrid.tsx
  • Breadcrumbs.tsx
  • BugBountyCards.tsx
  • ButtonLink.tsx

@pettinarip
Copy link
Member Author

wohooo! @SNikhill assigned! @Mousticke assigned as well (ButtonLink was already migrated, I've removed it from the list).

@vdusart assigned as well the C's

Thanks all! 🚀

@pettinarip pettinarip added Status: In Progress Work is in progress and removed Status: Up Next This issue has been prioritized to work on soon labels Sep 6, 2022
@ameeetgaikwad
Copy link
Contributor

Can I contribute?

@minimalsm
Copy link
Contributor

Hey @ameeetgaikwad, thanks for offering to help. We'd love your help on this :-) Is there a specific component you'd be interested in starting with?

@CodeNebulaX
Copy link

CodeNebulaX commented Sep 6, 2022

Can I contribute on these E-components?

  • EnergyConsumptionChart.tsx
  • EthVideo.tsx
  • EventCard.tsx
  • ExpandableCard.tsx
  • ExpandableInfo.tsx

@ameeetgaikwad
Copy link
Contributor

Hey @ameeetgaikwad, thanks for offering to help. We'd love your help on this :-) Is there a specific component you'd be interested in starting with?

Hey @minimalsm I recently learnt the basic of react. Please refer me a component which you see fit.

@pettinarip
Copy link
Member Author

Hey @EatCrypto thanks for reaching out and trying to help us with this migration. We are only assigning multiple files to old contributors for now.

I've assigned EnergyConsumptionChart.tsx to you. Once you finish with that one, we can assign you another one ✌🏼

@rishisundar
Copy link
Contributor

Hey, can I work on something? Don't have any preference. Would love to contribute!

@nikkhielseath
Copy link
Contributor

@pettinarip

I have made the suggested changes to the ActionCard in #8009.
Sorry for the delay.

@pettinarip
Copy link
Member Author

Thanks @SNikhill!

Hey @rishisundar we've just created a new GH issue to start migrating our pages and templates, check it out! #9353

@TylerAPfledderer
Copy link
Contributor

@MahendraBishnoi29 @AliTechGeek52 Hey there! 👋

I'm helping out with the migrations here. I see that there are components still assigned to you that do not appear to have PRs up.

Dismissable and RandomAppList, respectively.

Are you still able to complete these components, or need some assistance? 😀

@MahendraBishnoi29
Copy link
Contributor

@MahendraBishnoi29 @AliTechGeek52 Hey there! 👋

I'm helping out with the migrations here. I see that there are components still assigned to you that do not appear to have PRs up.

Dismissable and RandomAppList, respectively.

Are you still able to complete these components, or need some assistance? 😀

hey, @TylerAPfledderer thanks for helping here. so I've discussed with @pettinarip that DismissableCard is not in use currently so I haven't made a PR yet but if you still want me to make a PR I'll do it 😀

@TylerAPfledderer
Copy link
Contributor

TylerAPfledderer commented Mar 18, 2023

@MahendraBishnoi29 No need! That is Pablo's call to roll with 🤘

Thank you for your response! I'm seeing what I can do to help get these migrations to the finish line. 😄

@MahendraBishnoi29
Copy link
Contributor

appreciate your help @TylerAPfledderer

@pettinarip
Copy link
Member Author

🚀 🚀 🚀

Thanks everyone!! closing now. Amazing community work :) 🕺🏼

🚀 🚀 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic 💪 This issue is an epic on our product roadmap Status: In Progress Work is in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.