Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate NakedButton component #9519

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Deprecate NakedButton component #9519

merged 1 commit into from
Feb 20, 2023

Conversation

wackerow
Copy link
Member

Description

  • Deprecate NakedButton component, and replace with use of Chakra components
  • Uses IconButton for icons used as buttons without any text
  • Adds "Clear" string to common.json for aria label
  • Removes use of a button for hash link on run-a-node page

Related Issue

@wackerow
deprecate NakedButton component
b7b2ba4 
replace with Chakra components
@wackerow wackerow marked this pull request as ready for review February 17, 2023 23:31
@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 labels Feb 17, 2023
@wackerow wackerow mentioned this pull request Feb 17, 2023
Closed
80 tasks
@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 18, 2023

✅ ethereum-org-website-dev deploy preview ready

pettinarip
pettinarip approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! nicely done @wackerow

@pettinarip pettinarip merged commit baca29a into dev Feb 20, 2023
@pettinarip pettinarip deleted the naked-button branch February 20, 2023 14:42
@corwintines corwintines mentioned this pull request Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pettinarip pettinarip pettinarip approved these changes

@samajammin samajammin Awaiting requested review from samajammin

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

@jmcook1186 jmcook1186 Awaiting requested review from jmcook1186

Assignees
No one assigned
Labels
archived: chakra-migration content 🖋️ This involves copy additions or edits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wackerow @pettinarip