partition #488
Draft
partition #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #488 +/- ##
========================================
Coverage ? 92%
========================================
Files ? 23
Lines ? 11188
Branches ? 0
========================================
Hits ? 10294
Misses ? 894
Partials ? 0
Continue to review full report at Codecov.
|
joostvanzwieten
force-pushed
the
partition
branch
from
bd59cf3 to
574a460
Compare
joostvanzwieten
force-pushed
the
partition
branch
2 times, most recently
from
8b759c1 to
381c572
Compare
joostvanzwieten
force-pushed
the
partition
branch
from
381c572 to
2b816ab
Compare
joostvanzwieten
force-pushed
the
partition
branch
from
2b816ab to
8017f8c
Compare
joostvanzwieten
force-pushed
the
partition
branch
2 times, most recently
from
3479309 to
e6d9845
Compare
joostvanzwieten
force-pushed
the
partition
branch
from
e6d9845 to
eeb7a99
Compare
The multipatch topology is rather difficult to maintain in its current form while transitioning to tensorial topologies. We simply disable the tests involving multipatch topologies for now.
Bifurcate is being replaced by the new tensorial topologies approach. We disable unittests involving bifurcate pending the replacement.
The tests for `function.Basis` make heavily use of parametrize. This has two drawbacks: an exception raised while creating an argument, e.g. a transforms sequence, makes the entire module not importable, and we can't create helper variables for defining arguments unless we place them in the global scope. This patch solves both problems by replacing parametrize with dedicated subclasses.
Currently a `transform.Identity` is a subclass of `transform.Shift`. In `StructuredTransforms.index_with_tail` we test if the supplied transform chain starts with a `transform.Shift` using `isinstance`, which gives a false positive if the transform chain starts with `transform.Identity`. This patch resolves this problem by replacing `isinstance(t, T)` with `type(t) == T`.
In the past transform chains had a special root transform item. This concept does not exist anymore and we can safely remove `function.PopHead`. `function.PopHead` was only used in `ApplyTransforms(PopHead(ndims, SelectChain())`, where `SelectChain` is implicit. Since `function.SelectChain` does not yet know the dimension of the root, we temporarily replace `PopHead` with `TransformChainWithTodims`, with the sole purpose of defining the `todims`. In a follow-up commit `function.SelectChain` will gain this knowledge and `TransformChainWithTodims` will be removed in its entirety.
Now that we don't pop the head of a transform chain anymore, we can safely remove the root transform item from `StructuredTransforms`.
In a future commit the transforms may have inhomogeneous `fromdims`. This patch replaces all usage of the `fromdims` attribute.
joostvanzwieten
force-pushed
the
partition
branch
from
ba6b3d8 to
2a0355d
Compare
joostvanzwieten
force-pushed
the
partition
branch
from
2a0355d to
e1e208d
Compare
joostvanzwieten
force-pushed
the
partition
branch
from
e1e208d to
768b8be
Compare
joostvanzwieten
force-pushed
the
partition
branch
from
768b8be to
151b903
Compare
The default implementation of `__bool__` tests whether the volume is strict positive. For trimmed elements this can be rather expensive. This patch adds specialized implementations of `__bool__` for all element types.
joostvanzwieten
force-pushed
the
partition
branch
from
151b903 to
7380aa1
Compare
joostvanzwieten
force-pushed
the
partition
branch
from
66c729a to
d2a4ca6
Compare
Formerly locate made an initial selection of candidate elements based on (scaled) bounding boxes. The new implementation simply orders elements by centroid proximity, with an option to set a cutoff radius in case fast failure is required.
joostvanzwieten
force-pushed
the
partition
branch
from
8bf666c to
38dbbce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.