preserve input values on invite member form

[CREDO23]

Description

Fix #3111

Type of Change

• Bug fix
• New feature
• Breaking change
• Documentation update

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

Previous screenshots

Please add here videos or images of previous status

Current screenshots

Loom

Summary by CodeRabbit

• New Features

  • Enhanced AutoCompleteDropdown component with new properties for improved email selection management.
  • Integrated email selection directly into the input handling of the dropdown.

• Bug Fixes

  • Minor formatting adjustment to ensure consistent code quality.

These updates improve the overall user experience when selecting and managing email addresses within the application.

[coderabbitai]

Walkthrough

The changes in this pull request primarily enhance the AutoCompleteDropdown component by adding two new properties, setSelectedEmail and selectedEmail, to its props. These modifications allow for better management of email selection within the component. The dropdown's visual structure has been simplified by replacing the Card component with a div, and the Combobox input handling has been updated to reflect the current query state more effectively. The InviteEmailDropdown component has also been updated to integrate these new props, maintaining existing functionality.

Changes

File Path	Change Summary
apps/web/lib/components/auto-complete-dropdown.tsx	Added setSelectedEmail and selectedEmail to Props. Updated Combobox handling and dropdown rendering.
apps/web/lib/features/team/invite/invite-email-dropdown.tsx	Integrated new props into AutoCompleteDropdown. Minor formatting adjustment made.

Assessment against linked issues

Objective	Addressed	Explanation
Preserve input of name on Invite Team member (Issue #3111)	❌	Changes do not address input preservation issue.

Possibly related PRs

• [Feat]:Implement EditTaskModal component with enhanced task editing UI  #3238: The InviteEmailDropdown component adds the setSelectedEmail and selectedEmail props to the AutoCompleteDropdown, which directly relates to the changes made in the main PR that also introduces these props to enhance email selection management.

Suggested labels

feature

Suggested reviewers

• evereq

Poem

In the dropdown where emails play,
A new feature hops in today!
With selected emails now in sight,
Our invites will soar to new height.
So let’s celebrate, with joy and cheer,
For better invites are finally here! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web/lib/components/auto-complete-dropdown.tsx

Oops! Something went wrong! :(

ESLint: 8.46.0

ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct.

The config "next/core-web-vitals" was referenced from the config file in "/apps/web/.eslintrc.json".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)

apps/web/lib/components/auto-complete-dropdown.tsx (1)

Line range hint 75-93: Implementation aligns with PR objectives

The changes effectively address the core issue of preserving email input by:

1. Maintaining controlled input state through value={query}
2. Syncing the email state with parent component
3. Simplifying the UI structure for better visibility

However, consider adding a test case to verify the email preservation behavior.

Would you like me to help create test cases for the email preservation functionality?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1a1d0c6 and b99090d.

📒 Files selected for processing (2)

• apps/web/lib/components/auto-complete-dropdown.tsx (8 hunks)
• apps/web/lib/features/team/invite/invite-email-dropdown.tsx (2 hunks)

🔇 Additional comments (5)

apps/web/lib/features/team/invite/invite-email-dropdown.tsx (3)

Line range hint 9-22: Props structure looks good!

The component's props are well-typed and provide the necessary functionality for managing email selection state, which aligns with the PR objective of preserving input values.

---

Line range hint 23-56: Verify name input field visibility issue

While the email state management looks good, I don't see explicit handling of the name input field visibility issue mentioned in the PR objectives. This component only handles the email dropdown part.

Let's check if the name input field is handled elsewhere:

---

57-58: Verify AutoCompleteDropdown implementation

The new props setSelectedEmail and selectedEmail are passed to AutoCompleteDropdown, which should help preserve the email input. Let's verify the implementation:

apps/web/lib/components/auto-complete-dropdown.tsx (2)

7-7: LGTM: Type definitions are well-structured

The new props for email state management are properly typed and maintain backward compatibility by being optional.

Also applies to: 32-33

---

106-111: Verify contrast ratio with new background color

The switch to bg-slate-50 for the dropdown background should be tested for sufficient contrast with the text color.