-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync Parallel Letter Frequency tests with canonical specs #1365
Sync Parallel Letter Frequency tests with canonical specs #1365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks for doing it!
I only have a small request, could you format the @dostoevsky
strings with triple quotes:
@dostoevsky [
""""
I am a sick man.... I am a spiteful man. I am an unattractive man.
I believe my liver is diseased. However, I know nothing at all about my disease, and do not
[....]
""",
"""
Gentlemen, I am joking, and I know myself that my jokes are not brilliant
[...]
"""
]
And I think it's fine not to worry about an extra newline here or there in this case :)
9d855d9
to
f16ad1c
Compare
Thank you for contributing to Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:
Automated comment created by PR Commenter 🤖. |
Done ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thank you!
Hi !
I updated the tests to match the problem specifications.
A minor update of the
@reject_characters
RegExp in the example implementation was needed to pass the new tests.Relates to #1027 .