Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Parallel Letter Frequency tests with canonical specs #1365

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

antoine-duchenet
Copy link
Contributor

@antoine-duchenet antoine-duchenet commented Sep 15, 2023

Hi !

I updated the tests to match the problem specifications.
A minor update of the @reject_characters RegExp in the example implementation was needed to pass the new tests.

Relates to #1027 .

Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for doing it!
I only have a small request, could you format the @dostoevsky strings with triple quotes:

@dostoevsky [
  """"
  I am a sick man.... I am a spiteful man. I am an unattractive man.
  I believe my liver is diseased. However, I know nothing at all about my disease, and do not
  [....]
  """,
  """
  Gentlemen, I am joking, and I know myself that my jokes are not brilliant
  [...]
  """
  ]

And I think it's fine not to worry about an extra newline here or there in this case :)

@github-actions
Copy link
Contributor

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Practice exercise changed

    • 🌲 Do prerequisites, practices, and difficulty in config.json need to be updated?
    • 🧑‍🏫 Are the changes in accordance with the community-wide problem specifiations?
  • Practice exercise tests changed

    • ⚪️ Are all tests except the first one skipped?
    • 📜 Does <exercise>/.meta/tests.toml need updating?

Automated comment created by PR Commenter 🤖.

@antoine-duchenet
Copy link
Contributor Author

This is great, thanks for doing it! I only have a small request, could you format the @dostoevsky strings with triple quotes:

Done !

Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

@jiegillet jiegillet merged commit 9169c53 into exercism:main Sep 18, 2023
11 checks passed
@antoine-duchenet antoine-duchenet deleted the parallel-letter-frequency branch September 18, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants