Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dominoes: sync #1974

Merged
merged 1 commit into from
Aug 15, 2024
Merged

dominoes: sync #1974

merged 1 commit into from
Aug 15, 2024

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Aug 15, 2024

[no important files changed]

part of #1824

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@senekor senekor force-pushed the remo/nplsylryqwlx branch from 711b5c6 to 30f2971 Compare August 15, 2024 13:48
@senekor
Copy link
Contributor Author

senekor commented Aug 15, 2024

There is complicated validation logic here, which didn't make sense to copy-paste into every test case. But I didn't want to completely delete it either, because it produces nice error messages that can point users in the right direction about what went wrong.

As a compromise, I added a technically redundant assert!(output.is_some()) above the calls to assert_correct. Once the test code is included in the test runner, users will at least know whether Some or None was expected. How exactly the error message was produced - for that they'd need to open the test file.

@senekor senekor requested a review from ErikSchierboom August 15, 2024 13:54
@senekor senekor merged commit a8125d7 into main Aug 15, 2024
10 checks passed
@senekor senekor deleted the remo/nplsylryqwlx branch August 15, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants